-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrote VideoPresentation to tsx #2212
Merged
ipasic-softserve
merged 1 commit into
develop
from
bugfix/2204/video-presentation-to-tsx
Aug 2, 2024
Merged
Rewrote VideoPresentation to tsx #2212
ipasic-softserve
merged 1 commit into
develop
from
bugfix/2204/video-presentation-to-tsx
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ipasic-softserve
commented
Jul 26, 2024
•
edited
Loading
edited
- Rewrote VideoPresentation to tsx
- Fixed sonar issues
ipasic-softserve
requested review from
Olenka-Hryk,
YaroslavChuiko,
Mygal-Alex,
docia,
abalanovsky and
Mike-Popovych
July 26, 2024 11:34
abalanovsky
approved these changes
Jul 26, 2024
Olenka-Hryk
approved these changes
Jul 26, 2024
YaroslavChuiko
approved these changes
Jul 27, 2024
docia
approved these changes
Jul 28, 2024
ipasic-softserve
force-pushed
the
bugfix/2204/video-presentation-to-tsx
branch
from
July 29, 2024 11:35
a954211
to
553d308
Compare
Quality Gate passedIssues Measures |
Mike-Popovych
approved these changes
Jul 30, 2024
ipasic-softserve
added a commit
that referenced
this pull request
Aug 5, 2024
* change from "None" to "No category" * implement disabled state for none checked categories * remove unnessesary code * rewrite LoginForm.jsx to tsx * replace UseSelector by UseAppSelector * rewrite GoogleLogin to tsx format * rewrite OfferDetails to tsx format * rewrite LoginForm.jsx to tsx * replace UseSelector by UseAppSelector * remove unnessesary handleCheckboxChange function * remove unnessesary space * Changed image url concatenations to use createUrlPath helper * Update AccountIcon.tsx * Update createUrlPath in helper-functions.tsx * code fix * remove unnessesary space * Fix sonar: refactor to use an optional chain expression * Rewrote ProfileItem to tsx format (#2226) * Created tests for count-active-filters.tsx (#2191) * Rewrote DateFilter to tsx format and fixed sonar issues (#2240) * rewrote DateFilter to tsx * extended DesktopDatePickerProps * Rewrote SubjectsStep to tsx format (#2233) * Rewrote SubjectsStep to tsx format * fix sonar issue * fix sonar issue 2 * Rewrote FindBlock to tsx format (#2234) * Rewrote FindBlock to tsx format * fixed tests * Rewrote ProfileDoneItemsList to tsx format (#2235) * Rewrote ProfileDoneItemsList to tsx format * changed imports * Fixed privacy policy translation (#2153) * Fixed privacy policy translation * Fixed en version * Add an error tooltip for User Profile (#2164) * Add an error tooltip for User Profile * Add open on hover behaviour * Fix style: added gap and decreased error icon * Add an error tooltip to the personal info tab * Fix test * Fix linter errors * Update src/pages/edit-profile/EditProfile.tsx Co-authored-by: Olenka Hryk <[email protected]> * Refactor enableTooltipError to use optional chain expression --------- Co-authored-by: Olenka Hryk <[email protected]> * Fix error caused when category is cleared (#2205) * Rewrote ProfileContainerMobile to tsx (#2220) * Rewrote ProfileContainerMobile to tsx * Refactor doneItems type * Fix doneItems type * Rewrote ProfileContainerDesktop to tsx (#2223) * Rewrote ProfileContainerDesktop to tsx * Refactor doneItems type * Fix doneItems type * Rewrote SearchInput to tsx (#2210) * Rewrote SearchInput to tsx * Refactor setSearch to use React.Dispatch type * Rewrote VideoPresentation to tsx (#2212) * Rewrote EmailConfirmModal to tsx (#2244) * Rewrote AdminNavBarItem to tsx (#2237) * Rewrote SignupForm to tsx (#2238) * Rebase develop into feature/1944/change-image-url-concatenation * Update AccountIcon.tsx * Update createUrlPath in helper-functions.tsx * Fix sonar: refactor to use an optional chain expression --------- Co-authored-by: Bohdan <[email protected]> Co-authored-by: Bohdan Mylyi <[email protected]> Co-authored-by: PavloDolia <[email protected]> Co-authored-by: Anastasiia Matiushenko <[email protected]> Co-authored-by: Olenka Hryk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.