Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit container for Change Password and create popup #2188

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Edit container for Change Password and create popup #2188

merged 4 commits into from
Aug 5, 2024

Conversation

YulichkaR
Copy link
Contributor

Before:

2147_before

After:

2147_after

@YulichkaR YulichkaR added enhancement New feature or request Frontend part labels Jul 25, 2024
@YulichkaR YulichkaR self-assigned this Jul 25, 2024
@YulichkaR YulichkaR linked an issue Jul 25, 2024 that may be closed by this pull request
( SP: 2) Edit container for Change Password and create a modal popup for Password change #2147
Closed
2 tasks
@YaroslavChuiko
Copy link
Contributor

We have a custom hook useModalContext() in our project, can we use it here?

@YulichkaR
Copy link
Contributor Author

We have a custom hook useModalContext() in our project, can we use it here?

ty, reworked logic and used custom hook

@YaroslavChuiko YaroslavChuiko force-pushed the feature/2147/rework-change-password-container branch from af9e338 to 937d89d Compare July 29, 2024 15:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@YulichkaR YulichkaR requested review from Mygal-Alex and Mav-Ivan July 29, 2024 18:00
@YulichkaR YulichkaR merged commit 77d888f into develop Aug 5, 2024
3 checks passed
@YulichkaR YulichkaR deleted the feature/2147/rework-change-password-container branch August 5, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@abalanovsky abalanovsky abalanovsky approved these changes

@docia docia docia approved these changes

@YaroslavChuiko YaroslavChuiko YaroslavChuiko approved these changes

@Olenka-Hryk Olenka-Hryk Awaiting requested review from Olenka-Hryk

@Mygal-Alex Mygal-Alex Awaiting requested review from Mygal-Alex

Assignees

@YulichkaR YulichkaR

Labels
enhancement New feature or request Frontend part
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

( SP: 2) Edit container for Change Password and create a modal popup for Password change
5 participants
@YulichkaR @YaroslavChuiko @docia @abalanovsky @Mav-Ivan