Changed image url concatenations to use createUrlPath helper #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipasic-softserve
added
enhancement
ipasic-softserve
requested review from
docia,
YaroslavChuiko,
Olenka-Hryk,
abalanovsky and
Mike-Popovych
|
Something happened with a bunch of tests, check if this is caused by your changes and if so, fix those tests
|
Olenka-Hryk
approved these changes
Jul 25, 2024
docia
approved these changes
Jul 28, 2024
Mike-Popovych
approved these changes
Jul 29, 2024
ipasic-softserve
force-pushed
the
feature/1944/change-image-url-concatenation
branch
from
c143216 to
c28b02a
Compare
|
2 New issues will be fixed by merging these PRs: |
YaroslavChuiko
approved these changes
Jul 29, 2024
* rewrote DateFilter to tsx * extended DesktopDatePickerProps
* Rewrote SubjectsStep to tsx format * fix sonar issue * fix sonar issue 2
* Rewrote FindBlock to tsx format * fixed tests
* Rewrote ProfileDoneItemsList to tsx format * changed imports
* Fixed privacy policy translation * Fixed en version
* Add an error tooltip for User Profile * Add open on hover behaviour * Fix style: added gap and decreased error icon * Add an error tooltip to the personal info tab * Fix test * Fix linter errors * Update src/pages/edit-profile/EditProfile.tsx Co-authored-by: Olenka Hryk <[email protected]> * Refactor enableTooltipError to use optional chain expression --------- Co-authored-by: Olenka Hryk <[email protected]>
* Rewrote ProfileContainerMobile to tsx * Refactor doneItems type * Fix doneItems type
* Rewrote ProfileContainerDesktop to tsx * Refactor doneItems type * Fix doneItems type
…category-name Bugfix/2113/change category name
…e-login-form-tsx Rewrite LoginForm to tsx format and fix the sonar issues
…e-google-login-tsx Rewrite GoogleLogin to tsx format and fix the sonar issues
…e-offer-details-tsx Rewrite OfferDetails to tsx format and fix the sonar issues
* Rewrote SearchInput to tsx * Refactor setSearch to use React.Dispatch type
|
ipasic-softserve
deleted the
feature/1944/change-image-url-concatenation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed image url concatenations to use createUrlPath helper instead of template string