Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite EnhancedTableToolbar to typescript #2162

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Rewrite EnhancedTableToolbar to typescript #2162

merged 2 commits into from
Jul 29, 2024

Conversation

Mike-Popovych
Copy link
Contributor

  • Rewrote EnhancedTableToolbar to tsx format
  • Fixed sonar issues

@Mike-Popovych Mike-Popovych added the sonarFix fix the sonar issues label Jul 24, 2024
@Mike-Popovych Mike-Popovych self-assigned this Jul 24, 2024
@Mike-Popovych Mike-Popovych added the TypeScript Convert to TS label Jul 24, 2024
@Mike-Popovych Mike-Popovych linked an issue Jul 24, 2024 that may be closed by this pull request
(SP: 1) Rewrite EnhancedTableToolbar to tsx format and fix the sonar issuesм #2093
Closed
docia
docia approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@docia docia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent job!

@YaroslavChuiko
Copy link
Contributor

I just checked your branch locally and found that now we have two different versions of the same component
image

@Mike-Popovych Mike-Popovych force-pushed the bugfix/2093/EnhancedTableToolbar-to-tsx branch from 7f3d995 to 07351bc Compare July 24, 2024 15:08
@Mike-Popovych Mike-Popovych force-pushed the bugfix/2093/EnhancedTableToolbar-to-tsx branch from 07351bc to cc1eab6 Compare July 29, 2024 11:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Mike-Popovych Mike-Popovych merged commit 6635ed4 into develop Jul 29, 2024
3 checks passed
@Mike-Popovych Mike-Popovych deleted the bugfix/2093/EnhancedTableToolbar-to-tsx branch July 29, 2024 11:55
ipasic-softserve pushed a commit that referenced this pull request Aug 1, 2024
@Mike-Popovych @ipasic-softserve
Rewrite EnhancedTableToolbar to typescript (#2162)
dd3f626 
* rewrote EnhancedTableToolbar to tsx

* rewrote test according to component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalanovsky abalanovsky abalanovsky approved these changes

@docia docia docia approved these changes

@YaroslavChuiko YaroslavChuiko YaroslavChuiko approved these changes

@Olenka-Hryk Olenka-Hryk Olenka-Hryk approved these changes

@maarekua maarekua Awaiting requested review from maarekua

@YaroslavLys YaroslavLys Awaiting requested review from YaroslavLys

@byavdoshniak byavdoshniak Awaiting requested review from byavdoshniak

@Mygal-Alex Mygal-Alex Awaiting requested review from Mygal-Alex

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

@Marichka0406 Marichka0406 Awaiting requested review from Marichka0406

Assignees

@Mike-Popovych Mike-Popovych

Labels
sonarFix fix the sonar issues TypeScript Convert to TS
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 1) Rewrite EnhancedTableToolbar to tsx format and fix the sonar issuesм
5 participants
@Mike-Popovych @YaroslavChuiko @Olenka-Hryk @docia @abalanovsky