Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation in the placeholder when using Ukrainian interface on the My recourses page #2154

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix translation in the placeholder when using Ukrainian interface on the My recourses page #2154

merged 1 commit into from
Aug 5, 2024

Conversation

YulichkaR
Copy link
Contributor

@YulichkaR YulichkaR commented Jul 23, 2024 •
edited
Loading

Before:

2114_before

After:

2114_after

@YulichkaR YulichkaR added bug Something isn't working Frontend part labels Jul 23, 2024
@YulichkaR YulichkaR self-assigned this Jul 23, 2024
@YaroslavChuiko
Copy link
Contributor

  1. When we create PR we should link it to the issue which will be closed after merging this PR

Example:
image

  1. Also, we should mention team members who will be reviewers, you can find lately closed PR and see a list of people that you can add to the reviewers

image

@abalanovsky
Copy link
Contributor

abalanovsky commented Jul 24, 2024 •
edited
Loading

Also add Project and next time make your branch name shorter)

Знімок екрана 2024-07-24 о 12 17 59

@YulichkaR YulichkaR linked an issue Jul 24, 2024 that may be closed by this pull request
( SP: 0.5) Fix translation in the placeholder when using Ukrainian interface on the My recourses page #2114
Closed
1 task
@docia
Copy link
Contributor

docia commented Jul 24, 2024

please also remember to add your teammates to review your code ( Yaroslav mentioned above ). they are still missing ( :
PS. I've already added myself as a reviewer.

@docia docia self-requested a review July 24, 2024 10:08
@YulichkaR YulichkaR force-pushed the bugfix/2114/Fix-translation-in-the-placeholder-when-using-Ukrainian-interface-on-the-My-recourses-page branch from 8e3649d to 99e512f Compare July 29, 2024 10:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@YulichkaR YulichkaR merged commit dd0b6f1 into develop Aug 5, 2024
3 checks passed
@YulichkaR YulichkaR deleted the bugfix/2114/Fix-translation-in-the-placeholder-when-using-Ukrainian-interface-on-the-My-recourses-page branch August 5, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalanovsky abalanovsky abalanovsky approved these changes

@docia docia docia approved these changes

@YaroslavChuiko YaroslavChuiko YaroslavChuiko approved these changes

@Olenka-Hryk Olenka-Hryk Olenka-Hryk approved these changes

Assignees

@YulichkaR YulichkaR

Labels
bug Something isn't working Frontend part
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

( SP: 0.5) Fix translation in the placeholder when using Ukrainian interface on the My recourses page
5 participants
@YulichkaR @YaroslavChuiko @abalanovsky @docia @Olenka-Hryk