Added event handlers and a Redux store for cooperation #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olenka-Hryk
added
enhancement
Olenka-Hryk
requested review from
maarekua,
YaroslavChuiko,
YaroslavLys,
byavdoshniak,
Mygal-Alex,
docia,
y-matviichuk,
abalanovsky,
Mav-Ivan,
Marichka0406 and
Mike-Popovych
This was
linked to
issues
Jul 7, 2024
Closed
Closed
Olenka-Hryk
force-pushed
the
feature/1919/change-cooperation-date
branch
from
0956821 to
53b196b
Compare
Olenka-Hryk
commented
Jul 8, 2024
| useEffect(() => { | ||
| if (!sections?.length && !isAddedClicked && isNewActivity) { | ||
| addNewSection() | ||
| } | ||
|
|
||
| if (selectedCourse && !sections.length && isAddedClicked) { | ||
| if (selectedCourse && !sections?.length && isAddedClicked) { |
There was a problem hiding this comment.
This requires further investigation of all the useEffect logic. It will be addressed in issue #2064.
Also, I think we should delete unnecessary user action values (such as isActivityCreated, isAddedClicked, etc.) in the Redux store for Cooperation.
docia
approved these changes
Jul 9, 2024
D1nviz
approved these changes
Jul 9, 2024
mhevyk
approved these changes
Jul 9, 2024
3 tasks
abalanovsky
approved these changes
Jul 29, 2024
YaroslavChuiko
approved these changes
Jul 29, 2024
Olenka-Hryk
force-pushed
the
feature/1919/change-cooperation-date
branch
from
28ced44 to
0d1f3e7
Compare
….com/ita-social-projects/SpaceToStudy-Client into feature/2270/apply-main-changes-into-cooperation
…tps://github.com/ita-social-projects/SpaceToStudy-Client into feature/2070/change-create-course-functionality-to-new-handlers
|
Great work! |
mhevyk
approved these changes
Aug 16, 2024
…e Course & Cooperation
… by duplicating or linking
…tip, CourseSectionContainer, CooperationActivitiesList
…uplicating or linking
…ation-add-resource-in-two-ways Added the possibility to add a resource to a Cooperation in two ways: by duplicating or linking
…-create-course-functionality-to-new-handlers Replaced functionality of create course in order to use new handlers #2070
…main-changes-into-cooperation Refactored Cooperation & Course by Applying Main Requested Changes
…op-unique-id-section-issue Fixed drag-and-drop functionality and unique ID generation
…e-already-linked-resources Disabled already linked resources in Course/Cooperation in choose resources modals
…s-duplicate-icon-update Updated icon display based on resource addition method (link vs copy)
…-add-resource-in-two-ways Added the possibility to add a resource to a Course in two ways: by duplicating or linking
…licate-resource-validation Resolved BSONTypeError when adding duplicate resources to Course/Cooperation
…source-in-two-ways-duplicate-and-link Added the possibility to add a resource to a Cooperation / Course in two ways: by duplicating or linking
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored components by Single Responsibility Principle & added event handlers
The components have been refactored to follow to the SRP and decoupling the storage logic from presentation logic that makes the components to be reusable across different contexts. The refactored approach can be viewed via the following link: https://excalidraw.com/#json=7kpXFBlTDdFpOw4ERottv,BXDnxwSefLtlilkxienKZQ
[ PR #2061 ]
Implemented ability to change the availability status in '
My Cooperations' and store this information in the Redux storeNow, all changes to the availability status of resources on
ResourceItemsare persisted in the store:When the publish type is set to '
Open manually', the availability of all resources is automatically changed to 'Closed', and these changes are persisted in the store:Additionally, logic has been implemented to store the sort order of resources as individual items within each section. Previously, sorting was only implemented by group type, specifically for attachments, lessons, and quizzes, which only sorted groups but not the resources within them:
Breaking changes:
CreateCoursecomponent. [ Already implemented and fixed in Issue (SP: 3) Replace functionality of create course in order to use new handlers #2070 and PR Replaced functionality of create course in order to use new handlers #2070 #2316 ][ PR #2168 ]
Combined lessons, quizzes, and attachments into
activitiesarray in the cooperation storeChanged the cooperation store to combine the logic of storing attachments (
lessons,quizzes, andattachments) into a single variable -activities. Also removed theorderfield:[ PR #2290 ]
Refactored Cooperation & Course by Applying Main Requested Changes
Changed the name of the array
activitiestoresourcesand the type of resources from[lessons, quizzes, attachments, questions]to[lesson, quiz, attachment, question]. Current structure Cooperation and Course:[ PR #2303 ]
Fixed date serialization and mask input issues in DatePicker component
availability.dateis properly serialized to ISO string before dispatching actions:A non-serializable value (
Dateobject) was detected in the state, specifically in the path: cooperations.sections.0.resources.0.resource.availability.date. This warning is raised because Redux state should only contain plain serializable objects, arrays, and primitives. The reducer handling this action type iscooperationsSlice/updateResource.DatePickercomponent to use fixed-length date parts to resolve mask input warning.[ PR #2316 ]
Replaced functionality of create course in order to use new handlers
Updated the create course functionality to utilize the new handlers developed in PR #2061 after refactoring. The changes ensure that the course creation process works correctly when adding resources with the required entity data structure, as specified in PR #2290.
[ PR #2334 ]
Fixed [Error 409 (Conflict)] when saving cooperation with empty title or description
Resolved an issue where saving a cooperation with a section that has an empty title or description resulted in an Axios error with the message 'Request failed with status code 409'. After changes, it now shows a proper error popup message.
Tests Coverage for New Code:
🟣 Merged PRs:
🟢 Closed Issues:
Based on this epic Epic: Rewrite cooperation activities #1921, the following issues were implemented: