Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed translation on the Home Page and the input's width in the TitleBlock #2013

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fixed translation on the Home Page and the input's width in the TitleBlock #2013

merged 1 commit into from
Jul 4, 2024

Conversation

docia
Copy link
Contributor

@docia docia commented Jun 28, 2024 •
edited
Loading

  • fixed translation for TitleWithDescription on the Home Page
  • after the translation is fixed, reduced the input's width
  • updated scss class name for a Button.scss as it was missed in the already closed PR

Before:

Screenshot 2024-06-28 at 17 18 21 Screenshot 2024-06-28 at 17 28 23

After:

Screenshot 2024-06-28 at 17 38 57

@docia docia added bug Something isn't working Frontend part labels Jun 28, 2024
@docia docia self-assigned this Jun 28, 2024
@docia docia linked an issue Jun 28, 2024 that may be closed by this pull request
(SP: 0.5) Fix translation on Home Page for tutor and student #2012
Closed
2 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@docia docia merged commit 3ac4935 into develop Jul 4, 2024
3 checks passed
@docia docia deleted the bugfix/2012/fix-translation-and-input-width-on-homepage branch July 4, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Popovych Mike-Popovych Mike-Popovych approved these changes

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@abalanovsky abalanovsky abalanovsky approved these changes

@YaroslavChuiko YaroslavChuiko YaroslavChuiko approved these changes

@Olenka-Hryk Olenka-Hryk Olenka-Hryk approved these changes

@maarekua maarekua Awaiting requested review from maarekua

@YaroslavLys YaroslavLys Awaiting requested review from YaroslavLys

@byavdoshniak byavdoshniak Awaiting requested review from byavdoshniak

@y-matviichuk y-matviichuk Awaiting requested review from y-matviichuk

Assignees

@docia docia

Labels
bug Something isn't working Frontend part
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 0.5) Fix translation on Home Page for tutor and student
6 participants
@docia @Olenka-Hryk @YaroslavChuiko @abalanovsky @Mav-Ivan @Mike-Popovych