Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added course component #1412

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Added course component #1412

merged 4 commits into from
Nov 17, 2023

Conversation

Mav-Ivan
Copy link
Contributor

image

src/components/course-card/CourseCard.tsx Outdated Show resolved Hide resolved
src/components/course-card/CourseCard.tsx Outdated Show resolved Hide resolved
src/components/course-card/CourseCard.tsx Outdated Show resolved Hide resolved
minHeight: '245px',
backgroundColor: 'basic.white',
borderRadius: '6px',
p: '24px 24px 16px 24px'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p: '24px 24px 16px' should work too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you right

src/components/course-card/CourseCard.tsx Show resolved Hide resolved
sx={styles.chipContainer}
/>
<Typography sx={styles.secondaryText}>
{`${sections.length} ${sections.length > 1 ? 'sections' : 'section'}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this text should be in translation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dmtrth25 dmtrth25 self-requested a review November 17, 2023 11:02
@Mav-Ivan Mav-Ivan force-pushed the feature/1393/course-component branch from 4fbf209 to 1f279a4 Compare November 17, 2023 13:23
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.5% 98.5% Coverage
0.0% 0.0% Duplication

@Mav-Ivan Mav-Ivan merged commit b324dce into develop Nov 17, 2023
4 checks passed
@Mav-Ivan Mav-Ivan deleted the feature/1393/course-component branch November 17, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: 1) Create course component (as a card)
6 participants