Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed access token from local storage #1409

Merged
merged 2 commits into from
Nov 17, 2023
Merged

removed access token from local storage #1409

merged 2 commits into from
Nov 17, 2023

Conversation

Tolik170
Copy link
Contributor

@Tolik170 Tolik170 commented Nov 15, 2023 •
edited
Loading

Removed access token from local storage, now it will be stored in httpOnly cookie

@Tolik170 Tolik170 self-assigned this Nov 15, 2023
@Tolik170 Tolik170 linked an issue Nov 15, 2023 that may be closed by this pull request
(SP:1) Remove 'access token' from local storage #1397
Closed
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dmtrth25 dmtrth25 self-requested a review November 16, 2023 09:04
@dmtrth25
Copy link
Contributor

For better understanding you can add some description of where the token stored, screenshots etc.

@Tolik170 Tolik170 merged commit 307f46c into develop Nov 17, 2023
3 of 4 checks passed
@Tolik170 Tolik170 deleted the feature/remove-access-token-from-local-storage branch November 17, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalanovsky abalanovsky abalanovsky approved these changes

@MariaAfonina MariaAfonina MariaAfonina approved these changes

@dmtrth25 dmtrth25 dmtrth25 approved these changes

@TSlashDreamy TSlashDreamy TSlashDreamy approved these changes

@maarekua maarekua maarekua approved these changes

@OlyaKorchan OlyaKorchan OlyaKorchan approved these changes

@mynotdoing mynotdoing Awaiting requested review from mynotdoing

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

Assignees

@Tolik170 Tolik170

Labels
feature Frontend part
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP:1) Remove 'access token' from local storage
7 participants
@Tolik170 @dmtrth25 @OlyaKorchan @maarekua @TSlashDreamy @MariaAfonina @abalanovsky