Added chose category dropdown for new quiz #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynotdoing
requested review from
TSlashDreamy,
dmtrth25,
Tolik170,
abalanovsky,
MariaAfonina,
Marichka0406 and
Mav-Ivan
MariaAfonina
reviewed
Nov 9, 2023
mynotdoing
removed request for
TSlashDreamy,
dmtrth25,
Tolik170,
abalanovsky,
Mav-Ivan and
Marichka0406
Tolik170
reviewed
Nov 10, 2023
src/containers/my-quizzes/edit-quiz-container/EditQuizContainer.styles.ts
Outdated
Show resolved
Hide resolved
Tolik170
reviewed
Nov 10, 2023
src/containers/my-quizzes/edit-quiz-container/EditQuizContainer.styles.ts
Outdated
Show resolved
Hide resolved
Tolik170
reviewed
Nov 10, 2023
src/containers/my-quizzes/edit-quiz-container/EditQuizContainer.tsx
Outdated
Show resolved
Hide resolved
Tolik170
reviewed
Nov 10, 2023
src/containers/my-quizzes/edit-quiz-container/EditQuizContainer.tsx
Outdated
Show resolved
Hide resolved
Tolik170
reviewed
Nov 10, 2023
Tolik170
reviewed
Nov 10, 2023
src/containers/my-quizzes/edit-quiz-container/EditQuizContainer.tsx
Outdated
Show resolved
Hide resolved
|
Fix lint please |
Tolik170
reviewed
Nov 11, 2023
src/containers/my-quizzes/edit-quiz-container/EditQuizContainer.tsx
Outdated
Show resolved
Hide resolved
| "successAddedOuiz": "Ouiz was successtully created" | ||
| "successAddedOuiz": "Ouiz was successtully created", | ||
| "categoryDropdown": "Category...", | ||
| "categoryDropdownHelper": "Choose the category:" |
There was a problem hiding this comment.
Maybe better to move these translations to "common.json"? Because we need this for other pages.
| position: 'absolute', | ||
| top: '-33px', | ||
| left: '-14px' | ||
| } |
There was a problem hiding this comment.
Why are you using this variable? You use this style only once, so you can just write this in the 84-line.
| @@ -17,6 +17,8 @@ export interface QuizContentProps { | |||
| setDescription: Dispatch<SetStateAction<CreateQuizParams['description']>> | |||
| questions: Question[] | |||
| setQuestions: Dispatch<SetStateAction<Question[]>> | |||
| category: string | null | |||
There was a problem hiding this comment.
Maybe it's better to use category: Category | null?
mynotdoing
force-pushed
the
feature/1363/page_delails_for_current_quiz
branch
from
c6b3e82 to
000a245
Compare
Tolik170
approved these changes
Nov 21, 2023
TSlashDreamy
approved these changes
Nov 21, 2023
new_commit
mynotdoing
force-pushed
the
feature/1363/page_delails_for_current_quiz
branch
from
dbb9326 to
c38ad42
Compare
| @@ -37,6 +37,8 @@ | |||
| "fileSizeError": "Size for one file cannot be more than 10 MB.", | |||
| "noItems": "Елементів не знайдено", | |||
| "view": "Переглянути", | |||
| "categoryDropdown": "Категорія...", | |||
| "categoryDropdownHelper": "Оберіть категорію:", | |||
There was a problem hiding this comment.
You don't need this anymore. Delete this.
MariaAfonina
approved these changes
Nov 22, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added chose category dropdown for new quiz
2023-11-22.14.35.50.mov