Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resources to course section #1386

Merged
merged 24 commits into from
Nov 17, 2023
Merged

Add resources to course section #1386

merged 24 commits into from
Nov 17, 2023

Conversation

OlyaKorchan
Copy link
Contributor

Added possibility to add 3 types of resources to new course section. User can change resources order.

2023-11-09.18.31.04.mov

@OlyaKorchan OlyaKorchan self-assigned this Nov 9, 2023
@OlyaKorchan OlyaKorchan linked an issue Nov 9, 2023 that may be closed by this pull request
(SP: 2) Implement adding resorces for course section in new course #1310
Closed
@OlyaKorchan OlyaKorchan marked this pull request as draft November 9, 2023 16:44
@OlyaKorchan OlyaKorchan marked this pull request as ready for review November 10, 2023 09:48
@OlyaKorchan OlyaKorchan marked this pull request as draft November 10, 2023 17:23
@OlyaKorchan OlyaKorchan marked this pull request as ready for review November 10, 2023 18:48
Tolik170
Tolik170 reviewed Nov 13, 2023
View reviewed changes
src/components/icon-extension-with-title/IconExtensionWithTitle.tsx Outdated Show resolved Hide resolved
src/containers/add-resources/AddResources.constants.tsx Outdated Show resolved Hide resolved
src/containers/add-resources/AddResources.constants.tsx Outdated Show resolved Hide resolved
src/containers/add-resources/AddResources.tsx Outdated Show resolved Hide resolved
src/containers/course-section/CourseSectionContainer.constants.tsx Outdated Show resolved Hide resolved
src/containers/course-section/CourseSectionContainer.tsx Outdated Show resolved Hide resolved
src/containers/course-section/resource-item/ResourceItem.tsx Outdated Show resolved Hide resolved
src/containers/course-section/resource-item/ResourceItem.tsx Outdated Show resolved Hide resolved
src/containers/course-section/resource-item/ResourceItem.tsx Outdated Show resolved Hide resolved
src/containers/course-section/resource-item/ResourceItem.tsx Show resolved Hide resolved
MariaAfonina
MariaAfonina reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@MariaAfonina MariaAfonina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use "Category" from the "categories" field in my-resources-page to not create a new one in each resource?

OlyaKorchan and others added 10 commits November 15, 2023 19:58
@OlyaKorchan
fixed comments
88039dc
@MariaAfonina @OlyaKorchan
Implemented save logic in create quiz (#1388)
bd7b6ea 
* implemented-save-logic-in-create-quiz

* removed useForm and initialValues

* Changed NewQuiz to CreateQuizParams
@Mav-Ivan @OlyaKorchan
Add none property to resources (#1391)
003f31e 
* add none property to resources

* edited comments

* fixed typo

* moved item to variable
@mynotdoing @OlyaKorchan
added_exclusion_for_styles_sonar (#1407)
29fd739 
* added_exclusion_for_styles_sonar

* removed_sonar.test

* renewed_sonar.tests=./tests

* fixed_accidentially_deleted_styles.ts
@Tolik170 @OlyaKorchan
fetched resource categories and add create new category modal for new…
c018c2f 
… quiz page (#1374)

* fetch resources categories and add create new category modal for new question page

* fixed test

* added coverage
@OlyaKorchan
added modals for recources
eddc064
@OlyaKorchan
added correct recources drag and grop
f4abdb6
@OlyaKorchan
fixed comments
175c3a6
@OlyaKorchan
fixed quiz service and question modal after rebase
2cd3eee
@OlyaKorchan
Merge branch 'develop' into feature/1310/add-resources-to-course-section
39f202c
@OlyaKorchan
Copy link
Contributor Author

Maybe you can use "Category" from the "categories" field in my-resources-page to not create a new one in each resource?

Done

@OlyaKorchan OlyaKorchan requested a review from dmtrth25 November 15, 2023 20:55
@MariaAfonina MariaAfonina self-requested a review November 16, 2023 10:31
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.6% 86.6% Coverage
0.0% 0.0% Duplication

@OlyaKorchan OlyaKorchan merged commit 5d4f5e8 into develop Nov 17, 2023
4 checks passed
@OlyaKorchan OlyaKorchan deleted the feature/1310/add-resources-to-course-section branch November 17, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalanovsky abalanovsky abalanovsky left review comments

@MariaAfonina MariaAfonina MariaAfonina approved these changes

@Tolik170 Tolik170 Tolik170 approved these changes

@dmtrth25 dmtrth25 dmtrth25 approved these changes

@TSlashDreamy TSlashDreamy TSlashDreamy approved these changes

@maarekua maarekua maarekua approved these changes

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

Assignees

@OlyaKorchan OlyaKorchan

Labels
feature Frontend part
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 2) Implement adding resorces for course section in new course
9 participants
@OlyaKorchan @maarekua @TSlashDreamy @dmtrth25 @Tolik170 @MariaAfonina @abalanovsky @Mav-Ivan @mynotdoing