Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed mockedData at QuestionsList.spec.jsx #1199

Closed
wants to merge 1 commit into from
Closed

changed mockedData at QuestionsList.spec.jsx #1199

wants to merge 1 commit into from

Conversation

OlyaKorchan
Copy link
Contributor

@OlyaKorchan OlyaKorchan commented Sep 27, 2023 •
edited
Loading

Changed mocked data. Items changed to answers, _id added to question object
Fixes #1183

Test result after data change:
Знімок екрана 2023-09-27 о 17 38 21

@OlyaKorchan OlyaKorchan added bug Something isn't working Frontend part labels Sep 27, 2023
@OlyaKorchan OlyaKorchan self-assigned this Sep 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mxrcury
Copy link
Contributor

mxrcury commented Sep 27, 2023

I think it would be good to attach screenshots to description of ran QuestionsList.spec.jsx test before and after your fix

@OlyaKorchan OlyaKorchan linked an issue Sep 27, 2023 that may be closed by this pull request
(SP:1) Fixed test Questions #1183
Closed
@OlyaKorchan OlyaKorchan closed this Oct 3, 2023
@OlyaKorchan
Copy link
Contributor Author

Fixed in #1208

@OlyaKorchan OlyaKorchan deleted the bugFix/1183/fix-mocked-data-question-list branch October 3, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@abalanovsky abalanovsky abalanovsky approved these changes

@ArturBekhDEV ArturBekhDEV ArturBekhDEV approved these changes

@mxrcury mxrcury mxrcury approved these changes

@Tolik170 Tolik170 Tolik170 approved these changes

@maarekua maarekua maarekua approved these changes

Assignees

@OlyaKorchan OlyaKorchan

Labels
bug Something isn't working Frontend part test
Projects
SpaceToStudy
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP:1) Fixed test Questions
7 participants
@OlyaKorchan @mxrcury @maarekua @Tolik170 @ArturBekhDEV @abalanovsky @Mav-Ivan