fix edit profile tests

ita-social-projects · Nov 23, 2024 · b0694e3 · b0694e3
1 parent fc7e53e
commit b0694e3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/pages/edit-profile/EditProfile.tsx b/src/pages/edit-profile/EditProfile.tsx
@@ -90,6 +90,10 @@ const EditProfile = () => {
     return JSON.stringify(initialData) !== JSON.stringify(currentData)
   }
 
+  const isUpdatedPhoto = (photo: string | null | UpdatedPhoto): boolean => {
+    return photo !== null && typeof photo === 'object' && 'name' in photo
+  }
+
   const hasPhotoChanges = useCallback(
     (
       initialPhoto: string | null | UpdatedPhoto,
@@ -101,23 +105,23 @@ const EditProfile = () => {
 
       if (
         typeof initialPhoto === 'string' &&
-        (currentPhoto as UpdatedPhoto).name !== undefined &&
+        isUpdatedPhoto(currentPhoto) &&
         (currentPhoto as UpdatedPhoto).name !== initialPhoto
       ) {
         return true
       }
 
       if (
         initialPhoto === null &&
-        (currentPhoto as UpdatedPhoto).name !== undefined &&
+        isUpdatedPhoto(currentPhoto) &&
         areAllValuesEmptyStrings(currentPhoto as UpdatedPhoto)
       ) {
         return true
       }
 
       if (
-        (initialPhoto as UpdatedPhoto).name !== undefined &&
-        (currentPhoto as UpdatedPhoto).name !== undefined &&
+        isUpdatedPhoto(initialPhoto) &&
+        isUpdatedPhoto(currentPhoto) &&
         (initialPhoto as UpdatedPhoto).name !==
           (currentPhoto as UpdatedPhoto).name
       ) {

diff --git a/tests/unit/containers/edit-profile/profile-tab/profile-tab-form/ProfileTabForm.spec.jsx b/tests/unit/containers/edit-profile/profile-tab/profile-tab-form/ProfileTabForm.spec.jsx
@@ -56,7 +56,7 @@ describe('ProfileTabForm', () => {
     const removePhotoBtn = screen.getByRole('button', { name: 'common.remove' })
     fireEvent.click(removePhotoBtn)
 
-    expect(handleNonInputValueChange).toHaveBeenCalledWith('photo', null)
+    expect(handleNonInputValueChange).toHaveBeenCalledWith('photo', '')
   })
 
   it('should handle adding a photo', async () => {

diff --git a/tests/unit/redux/editProfileSlice.spec.js b/tests/unit/redux/editProfileSlice.spec.js
@@ -87,7 +87,7 @@ const initialState = {
   professionalSummary: '',
   nativeLanguage: '',
   videoLink: { [UserRoleEnum.Tutor]: '', [UserRoleEnum.Student]: '' },
-  photo: '',
+  photo: null,
   categories: { [UserRoleEnum.Tutor]: [], [UserRoleEnum.Student]: [] },
   professionalBlock: {
     education: '',