-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect field assignment in Offers #1095
Fixed incorrect field assignment in Offers #1095
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work! just please remove story points from PR title, they are supposed to be in the task title :)
#1092
languages
,proficiencyLevel
,userStatusEnum
by replacing inline enum definitions with a reusable schemas.categoryWithAppearance
and replaced thecategory
property with a reference to it.offerAuthorExtended
and replaced theauthor
property with a reference to it (inoffers
).subjectWithName
and replaced thesubject
property with a reference to it.FAQ
property schema to include an_id
field in each FAQ item.chatId
property to also accept null, in addition to the string value.enrolledUsers
property to use an array of strings instead of a reference to #components/userofferAuthor
schema and replaced theauthor
property with a reference to it (inoffer
).