Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect field assignment in Offers #1095

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

nebby2105
Copy link
Contributor

@nebby2105 nebby2105 commented Dec 25, 2024

#1092

  • Removed duplicated values for languages, proficiencyLevel, userStatusEnum by replacing inline enum definitions with a reusable schemas.
Screenshot 2024-12-25 at 15 06 42 Screenshot 2024-12-25 at 15 06 58 Screenshot 2024-12-25 at 15 08 11
  • Created a new schema categoryWithAppearance and replaced the category property with a reference to it.
Screenshot 2024-12-25 at 15 11 54
  • Created a new schema offerAuthorExtended and replaced the author property with a reference to it (in offers).
Screenshot 2024-12-25 at 15 15 23
  • Created a new schema subjectWithName and replaced the subject property with a reference to it.
Screenshot 2024-12-25 at 15 20 04
  • Updated the FAQ property schema to include an _id field in each FAQ item.
  • Updated the chatId property to also accept null, in addition to the string value.
  • Updated the enrolledUsers property to use an array of strings instead of a reference to #components/user
  • Created a new offerAuthor schema and replaced the author property with a reference to it (in offer).
  • Updated example data for better representation of the API response.
  • Removed unnecessary reference ($ref or ref) to other schemas where needed

@nebby2105 nebby2105 self-assigned this Dec 25, 2024
@nebby2105 nebby2105 changed the title fixed incorrect field assignment in offers and so (SP: 2) Fixed incorrect field assignment in Offers Dec 25, 2024
@nebby2105 nebby2105 added bug Something isn't working Backend documentation Improvements or additions to documentation labels Dec 25, 2024
@nebby2105 nebby2105 marked this pull request as ready for review December 25, 2024 13:42
Copy link
Contributor

@ShadowOfTheSpace ShadowOfTheSpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@dudchakk dudchakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work! just please remove story points from PR title, they are supposed to be in the task title :)

@nebby2105 nebby2105 changed the title (SP: 2) Fixed incorrect field assignment in Offers Fixed incorrect field assignment in Offers Dec 28, 2024
@nebby2105 nebby2105 merged commit 0a5c499 into develop Dec 28, 2024
4 checks passed
@nebby2105 nebby2105 deleted the bugfix/1092/incorrect-field-assignment-offer branch December 28, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants