modificate update question endpoint (#617)

ita-social-projects · Nov 7, 2023 · 13c4546 · 13c4546
1 parent 93403b9
commit 13c4546
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 7 deletions.
diff --git a/controllers/question.js b/controllers/question.js
@@ -40,9 +40,10 @@ const updateQuestion = async (req, res) => {
   const { id } = req.params
   const { id: currentUserId } = req.user
   const data = req.body
-  await questionService.updateQuestion(id, currentUserId, data)
 
-  res.status(204).end()
+  const updatedQuestion = await questionService.updateQuestion(id, currentUserId, data)
+
+  res.status(200).json(updatedQuestion)
 }
 
 module.exports = {

diff --git a/docs/questions/question.yaml b/docs/questions/question.yaml
@@ -147,8 +147,8 @@ paths:
         - bearerAuth: []
       tags:
         - Questions
-      summary: Update question by id.
-      description: Updates question by id.
+      summary: Updates question by id and return it.
+      description: Updates question by id and return it.
       produces:
         - application/json
       parameters:
@@ -166,8 +166,26 @@ paths:
             example:
               title: WebAssembly
       responses:
-        204:
-          description: No content
+        200:
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#definitions/question'
+              example:
+                _id: 63ec1cd51e9d781cdb6f4b14
+                title: WebAssembly
+                text: What is the chemical symbol for water?
+                answers:
+                  - text: First answer
+                    isCorrect: true
+                  - text: Second answer
+                    isCorrect: false
+                type: multipleChoice
+                author: 63da8767c9ad4c9a0b0eacd3
+                category: { _id: 6477007a6fa4d05e1a800ce1, name: Science }
+                createdAt: 2023-02-14T23:44:21.334Z
+                updatedAt: 2023-02-14T23:44:21.334Z
         401:
           description: Unauthorized
           content:

diff --git a/services/question.js b/services/question.js
@@ -55,7 +55,9 @@ const questionService = {
     for (let field in data) {
       question[field] = data[field]
     }
+
     await question.save()
+    return question.populate({ path: 'category', select: '_id name' })
   }
 }
 

diff --git a/test/integration/controllers/question.spec.js b/test/integration/controllers/question.spec.js
@@ -126,7 +126,7 @@ describe('Question controller', () => {
         .patch(endpointUrl + testQuestionId)
         .send(updateData)
         .set('Authorization', `Bearer ${accessToken}`)
-      expect(response.statusCode).toBe(204)
+      expect(response.statusCode).toBe(200)
 
       const updatedQuestion = await Question.findById(testQuestionId)