Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquibase redundante records #1558

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

holotsvan
Copy link
Collaborator

@holotsvan holotsvan commented Dec 16, 2024

dev

Issue

ita-social-projects/GreenCity#7947

Summary of issue

There are a lot of redendant changeLogs which are adding something, that this something is deleting and etc.

Summary of change

  • Using liquibase pro create changeLog on new initialized db (free version has limitations on entities which would be copied)
liquibase \
   --driver=org.postgresql.Driver \
   --url="jdbc:postgresql://localhost:5432/<db>" \
   --changeLogFile="db-changelog-full.xml" \
   --username=postgres \
   --password=<password>  \
   --logLevel=info  \ 
   --defaultSchemaName=public  \
   --diffTypes=catalogs,checkconstraints,columns,data,databasepackage,databasepackagebody,foreignkeys,functions,indexes,primarykeys,sequences,storedprocedures,tables,triggers,uniqueconstraints,views \
   --liquibaseProLicenseKey=<key> \
    generateChangeLog
  • Change tags with pro: to their alternatives from free version
  • add preconditions to each changeSet

Testing approach

  • Initialize new db using this changeLog
  • Run on old db with new changelog to see that everything runs fun

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link
Contributor

@LazarenkoDmytro LazarenkoDmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants