[Bugfix] #5446 order data update #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliiakaras
requested review from
Lokankara,
bzhn,
kovalsofiia1 and
kryzanivska-nastya
Lokankara
approved these changes
Nov 19, 2024
| map((response) => { | ||
| if (response.body) { | ||
| this.snackBar.openSnackBar('changesSaved'); | ||
| return UpdateOrderInfoSuccess({ updatedOrder: response.body as IBigOrderTableOrderInfo }); |
There was a problem hiding this comment.
To avoid explicit type casting, you can modify the response body properly:
updateOrderInfo():Observable<HttpResponse<IBigOrderTableOrderInfo>>
| @@ -30,16 +29,15 @@ import { | |||
| ReturnMoneyOrBonuses | |||
| } from '../../models/ubs-admin.interface'; | |||
There was a problem hiding this comment.
Unused imports specifier IPaymentInfo, IAddressExportDetails, ViewChild
Unused field isDataLoaded
Also pay attention on sonar issues
| @@ -582,8 +533,9 @@ export class UbsAdminOrderComponent implements OnInit, OnDestroy, AfterContentCh | |||
| for (const formControlName in formItem.controls) { | |||
| if (Object.prototype.hasOwnProperty.call(formItem.controls, formControlName)) { | |||
| const formControl = formItem.controls[formControlName]; | |||
|
|
|||
| if (formControl instanceof FormControl) { | |||
| if (formControlName === 'userInfoDto' && formControl.dirty) { | |||
There was a problem hiding this comment.
Repeated logic for type checks and value assignment is extracted into helper methods, reducing redundancy.
Centralize the logic for dirty checks, etc
private isFormControl(item: AbstractControl): item is FormControl { return item instanceof FormControl; }
kryzanivska-nastya
approved these changes
Nov 19, 2024
Lokankara
approved these changes
Nov 25, 2024
|
Tadei-Mykola
approved these changes
Nov 25, 2024
hnativlyubomyr
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5446