BREAKING CHANGE: change EventTime enum #7899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -1,6 +1,6 @@ | |||
| package greencity.enums; | |||
|
|
|||
| public enum EventTime { | |||
| FUTURE, | |||
There was a problem hiding this comment.
I see that we use FUTURE here
Do you think we should update it as well?
| @@ -145,7 +145,7 @@ private Predicate getPredicate(FilterEventDto filterEventDto, Long userId, Root< | |||
| private void addEventTimePredicate(EventTime eventTime, Root<Event> eventRoot, List<Predicate> predicates) { | |||
| if (eventTime != null) { | |||
| ListJoin<Event, EventDateLocation> datesJoin = eventRoot.join(Event_.dates, JoinType.LEFT); | |||
| if (eventTime == EventTime.FUTURE) { | |||
| if (eventTime == EventTime.UPCOMING) { | |||
There was a problem hiding this comment.
how do you want me to test it? with unit or integration test? I don't quite get how to unit test it, there's so many thing I need to mock. integration test will be way easier to write in this case, don't you agree?
| @@ -145,7 +145,7 @@ private Predicate getPredicate(FilterEventDto filterEventDto, Long userId, Root< | |||
| private void addEventTimePredicate(EventTime eventTime, Root<Event> eventRoot, List<Predicate> predicates) { | |||
| if (eventTime != null) { | |||
| ListJoin<Event, EventDateLocation> datesJoin = eventRoot.join(Event_.dates, JoinType.LEFT); | |||
| if (eventTime == EventTime.FUTURE) { | |||
| if (eventTime == EventTime.UPCOMING) { | |||
| predicates.add( | |||
| criteriaBuilder.greaterThan(datesJoin.get(EventDateLocation_.FINISH_DATE), ZonedDateTime.now())); | |||
| } else if (eventTime == EventTime.PAST) { | |||
There was a problem hiding this comment.
Why do we need else if here?
There are only 2 items in the EventTime enum
I think it is better to have 2 separate if here
LazarenkoDmytro
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreenCity PR
Issue Link 📋
#6824
Changed
Summary of Changes
This change should fix the bug from issue #6824, if merged at the same time with front-end fix.