7817 fix api response status 500 instead of 400 when coordinates not specified #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cr1stal423
changed the title
Cr1stal423
changed the title
| for (EventDateLocationDto eventDateLocationDto : eventDateLocationDtos) { | ||
| AddressDto coordinates = eventDateLocationDto.getCoordinates(); | ||
|
|
||
| if (coordinates == null || coordinates.getLatitude() == null || coordinates.getLongitude() == null) { |
There was a problem hiding this comment.
maybe make sens use Objects.isNull() ckeck
| double latitude = coordinates.getLatitude(); | ||
| double longitude = coordinates.getLongitude(); | ||
|
|
||
| if (latitude < -90.0 || latitude > 90.0 || longitude < -180.0 || longitude > 180.0) { |
There was a problem hiding this comment.
maybe move this check to separate method?
| .latitude(ModelUtils.getAddressDto().getLatitude()) | ||
| .longitude(ModelUtils.getAddressDto().getLongitude()) | ||
| .build(); | ||
| when(modelMapper.map(ModelUtils.getAddressLatLngResponse(), AddressDto.class)).thenReturn(build); |
There was a problem hiding this comment.
move this AddressDto builder to ModelsUtils class
… ModelUtils, replace '==' with Objects.isNull(), extract coordinate validation to a separate method
nazariusPr
approved these changes
Dec 3, 2024
holotsvan
reviewed
Dec 3, 2024
| } | ||
|
|
||
| private boolean isValidCoordinate(double latitude, double longitude) { | ||
| return latitude >= -90.0 && latitude <= 90.0 && longitude >= -180.0 && longitude <= 180.0; |
There was a problem hiding this comment.
return Math.abs(latitude) <= 90.0 && Math.abs(longitude) <= 180.0;what about such solution?
holotsvan
approved these changes
Dec 3, 2024
ChernenkoVitaliy
approved these changes
Dec 3, 2024
| @@ -179,6 +179,9 @@ public class ErrorMessage { | |||
| public static final String USER_HAS_NO_FRIEND_WITH_ID = "User has no friend with this id: "; | |||
| public static final String INVALID_DURATION = "The duration for such habit is lower than previously set"; | |||
| public static final String ADDRESS_NOT_FOUND_EXCEPTION = "No address found for the given coordinates."; | |||
| public static final String INVALID_COORDINATES = "The coordinates field must not be empty"; | |||
| public static final String INVALID_LONGITUDE = "Longitude must be between -180 and 180 degrees"; | |||
| public static final String INVALID_LATITUDE = "Latitude must be between -90 and 90 degrees"; | |||
There was a problem hiding this comment.
Why do you need constants INVALID_LONGITUDE and INVALID_LATITUDE?
You don't use them anywhere.
|
Cr1stal423
deleted the
7817-fix-api-response-status-500-instead-of-400-when-coordinates-not-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreenCity PR
Issue Link:
7817
Changes:
Current Behavior:
The response now indicates when coordinates are not specified.