Update custom habit implementation change #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maksym-Lenets
approved these changes
Oct 5, 2023
ABbondar
approved these changes
Oct 5, 2023
HelenSotnik
changed the title
| @@ -944,6 +905,8 @@ void updateCustomHabitWithOneParameterToUpdateTest() throws IOException { | |||
| assertEquals(customHabitDtoResponse, | |||
| habitService.updateCustomHabit(customHabitDtoRequest, 1L, "[email protected]", image)); | |||
|
|
|||
| verify(customShoppingListItemRepo, times(2)).findAllByUserIdAndHabitId(2L, 1L); | |||
| // verify(customShoppingListItemRepo).save(any()); | |||
There was a problem hiding this comment.
please remove it if it is unused
There was a problem hiding this comment.
It is used, I have forgotten to uncomment it, already did.
| } | ||
|
|
||
| private void updateHabitTranslationsForCustomHabit(CustomHabitDtoRequest habitDto, Habit habit) { | ||
| HabitTranslationDto habitTranslationDto = habitDto.getHabitTranslations().get(0); |
There was a problem hiding this comment.
can we have indexoutofboundexception here?
please use findFirst
2or5
approved these changes
Oct 6, 2023
RomaMocherniuk
approved these changes
Oct 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreenCity PR
Add ability to edit custom habits which user has created #6214
Summary Of Changes 🔥
Changed update of collections (HabitTranslations and CustomShoppingListItem).
for CustomShoppingListItem now: