Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GreenCity] changes in EventServiceImpl getAllFilteredEvents and getAllEventsAddresses() #6488

Closed
wants to merge 5 commits into from

Conversation

HelenSotnik
Copy link
Contributor

@HelenSotnik HelenSotnik commented Oct 2, 2023

GreenCity PR

Change of getAllFilteredEvents method for anonymous user and logged in user.
Changed endpoint with addresses.
Added check for events CollectionUtils.isNotEmpty before use of methods setFollowers and setSubscribers.

Summary Of Changes 🔥

  • getAllFilteredEvents() change for anonymous user and logged in user scenarios.
  • getAllEventsAddresses() before returned collection of addresses in events, but only from last EventDateLocation in dates field in Events(which is supposed to be relevant), now returns all addresses from all events.
  • filterByLocation() changed in order to filterEvents by all addresses
  • added check for events CollectionUtils.isNotEmpty before use of methods setFollowers and setSubscribers, because if collection is empty occurs SQL exception, now if collection of events is empty in case when user is logged in it returns empty PageableAdvancedDto.

PR Checklist Forms

(to be filled out by PR submitter)

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-XXXX: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells ar duplication
  • All files reviewed before sending to reviewers

@HelenSotnik HelenSotnik changed the title Commit with changes in findAll events [GreenCity] changes in EventServiceImpl getAllFilteredEvents and getAllEventsAddresses() Oct 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

99.0% 99.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@HelenSotnik HelenSotnik deleted the get-all-events-addresses-method-change branch October 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant