Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct response in econews/comments/replies/{parentCommentId} #6487

Merged
merged 2 commits into from
Oct 2, 2023
Merged

correct response in econews/comments/replies/{parentCommentId} #6487

merged 2 commits into from
Oct 2, 2023

Conversation

LiliaMokhnatska
Copy link
Contributor

@LiliaMokhnatska LiliaMokhnatska commented Oct 2, 2023 •
edited
Loading

Summary Of Issue :

The response is 200 instead 404 when enter not existing parameter of parentCommentId

Issue Link
#6367

Summary Of Changes :

1)changed findAllReplies method in EcoNewsCommentServiceImpl
2)added findAllByParentCommentId method in EcoNewsCommentRepo
3)added new error message
4) added new test in EcoNewsCommentServiceImplTest

CHECK LIST

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells ar duplication
  • NEED_REVIEW and READY_FOR_REVIEW labels are added.
  • All files reviewed before sending to reviewers

@LiliaMokhnatska
1)changed findAllReplies method in EcoNewsCommentServiceImpl
5625ff3 
2)added findAllByParentCommentId method in EcoNewsCommentRepo
3)added new error message
4) added new test in EcoNewsCommentServiceImplTest
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@LiliaMokhnatska LiliaMokhnatska merged commit bbd5175 into dev Oct 2, 2023
3 checks passed
@LiliaMokhnatska LiliaMokhnatska deleted the eco_news_comment_replies_not_correct_response branch October 2, 2023 14:35
ospodaryk pushed a commit that referenced this pull request Oct 4, 2023
@LiliaMokhnatska @ospodaryk
correct response in econews/comments/replies/{parentCommentId} (#6487)
efebc06 
* 1)changed findAllReplies method in EcoNewsCommentServiceImpl
2)added findAllByParentCommentId method in EcoNewsCommentRepo
3)added new error message
4) added new test in EcoNewsCommentServiceImplTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospodaryk ospodaryk ospodaryk approved these changes

@ABbondar ABbondar ABbondar approved these changes

@Yurii-Midianyi Yurii-Midianyi Yurii-Midianyi approved these changes

@2or5 2or5 Awaiting requested review from 2or5

@Maksym-Lenets Maksym-Lenets Awaiting requested review from Maksym-Lenets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiliaMokhnatska @Yurii-Midianyi @ABbondar @ospodaryk