Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug update score #6420

Merged
merged 16 commits into from
Oct 4, 2023
Merged

Fix bug update score #6420

merged 16 commits into from
Oct 4, 2023

Conversation

ospodaryk
Copy link
Contributor

@ospodaryk ospodaryk commented Sep 26, 2023 •
edited
Loading

GreenCity PR

Bug-update user score dont work #6422

Summary Of Changes 🔥

Added new method to save user
Updated old implementation of rating service

PR Checklist Forms

(to be filled out by PR submitter)

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-XXXX: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells ar duplication
  • NEED_REVIEW and READY_FOR_REVIEW labels are added.
  • All files reviewed before sending to reviewers

@ospodaryk ospodaryk force-pushed the fix-bug-update-score branch 2 times, most recently from 86a045e to f31e6c8 Compare October 4, 2023 10:29
@ospodaryk ospodaryk force-pushed the fix-bug-update-score branch from 96dbabe to ec42adb Compare October 4, 2023 10:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ospodaryk ospodaryk merged commit df4297d into dev Oct 4, 2023
@ospodaryk ospodaryk deleted the fix-bug-update-score branch October 4, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiliaMokhnatska LiliaMokhnatska LiliaMokhnatska approved these changes

@HelenSotnik HelenSotnik HelenSotnik approved these changes

@ABbondar ABbondar ABbondar approved these changes

@RomaMocherniuk RomaMocherniuk RomaMocherniuk approved these changes

@Maksym-Lenets Maksym-Lenets Awaiting requested review from Maksym-Lenets

@2or5 2or5 Awaiting requested review from 2or5

@Yurii-Midianyi Yurii-Midianyi Awaiting requested review from Yurii-Midianyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ospodaryk @RomaMocherniuk @ABbondar @HelenSotnik @LiliaMokhnatska