Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of new endpoint GET[/place/all] #6360

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Addition of new endpoint GET[/place/all] #6360

merged 4 commits into from
Sep 19, 2023

Conversation

HelenSotnik
Copy link
Contributor

@HelenSotnik HelenSotnik commented Sep 15, 2023 •
edited
Loading

GreenCityUBS PR

#1415 [GreenCity-Places] When the admin navigates to the 'Places' page, places are not displayed #5226

Summary Of Changes 🔥

  • new endpoint has been added in order to solve a problem with display of places for admin

Added

  • new endpoint GET[/place/all]
  • method in PlaceController getAllPlaces(Pageable page);
  • test method getAllplacesTest() added
  • security configuration for endpoint

@HelenSotnik HelenSotnik added this to the 36.6 milestone Sep 15, 2023
@HelenSotnik HelenSotnik linked an issue Sep 15, 2023 that may be closed by this pull request
#1415 [GreenCity-Places] When the admin navigates to the 'Places' page, places are not displayed #5226
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

RomaMocherniuk
RomaMocherniuk reviewed Sep 19, 2023
View reviewed changes
core/src/main/java/greencity/controller/PlaceController.java Outdated
@ApiOperation(value = "Get all places")
@ApiResponses(value = {
@ApiResponse(code = 200, message = HttpStatuses.OK),
@ApiResponse(code = 400, message = HttpStatuses.BAD_REQUEST),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we have BAD_REQUEST if there are no any input params?

@HelenSotnik HelenSotnik merged commit 697ce48 into dev Sep 19, 2023
2 checks passed
@HelenSotnik HelenSotnik deleted the findAll-places-endpoint-addition branch September 19, 2023 07:30
@ViktoriyaRyazhska ViktoriyaRyazhska removed this from the 36.6 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomaMocherniuk RomaMocherniuk RomaMocherniuk approved these changes

@ospodaryk ospodaryk ospodaryk approved these changes

@ABbondar ABbondar ABbondar approved these changes

@Yurii-Midianyi Yurii-Midianyi Yurii-Midianyi approved these changes

@VadymMakitra VadymMakitra Awaiting requested review from VadymMakitra

@2or5 2or5 Awaiting requested review from 2or5

@Maksym-Lenets Maksym-Lenets Awaiting requested review from Maksym-Lenets

@sergoliarnik sergoliarnik Awaiting requested review from sergoliarnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#1415 [GreenCity-Places] When the admin navigates to the 'Places' page, places are not displayed
6 participants
@HelenSotnik @RomaMocherniuk @Yurii-Midianyi @ABbondar @ospodaryk @ViktoriyaRyazhska