Change of implementation of habitTranslationDtoOptional

ita-social-projects · Oct 6, 2023 · d8023f2 · d8023f2
1 parent 9c629de
commit d8023f2
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/service/src/main/java/greencity/service/HabitServiceImpl.java b/service/src/main/java/greencity/service/HabitServiceImpl.java
@@ -434,15 +434,14 @@ private void updateExistingCustomShoppingListItems(CustomHabitDtoRequest habitDt
     private void updateHabitTranslationsForCustomHabit(CustomHabitDtoRequest habitDto, Habit habit) {
         Optional<HabitTranslationDto> habitTranslationDtoOptional = habitDto.getHabitTranslations().stream()
             .findFirst();
-        if (habitTranslationDtoOptional.isPresent()) {
-            HabitTranslationDto habitTranslationDto = habitTranslationDtoOptional.get();
-            List<HabitTranslation> habitTranslations = habitTranslationRepo.findAllByHabit(habit);
-            habitTranslations.forEach(habitTranslation -> {
-                habitTranslation.setName(habitTranslationDto.getName());
-                habitTranslation.setDescription(habitTranslationDto.getDescription());
-                habitTranslation.setHabitItem(habitTranslationDto.getHabitItem());
-            });
-        }
+        habitTranslationDtoOptional.ifPresent(habitTranslationDto -> {
+            habitTranslationRepo.findAllByHabit(habit)
+                .forEach(habitTranslation -> {
+                    habitTranslation.setName(habitTranslationDto.getName());
+                    habitTranslation.setDescription(habitTranslationDto.getDescription());
+                    habitTranslation.setHabitItem(habitTranslationDto.getHabitItem());
+                });
+        });
     }
 
     private void saveHabitTranslationListsToHabitTranslationRepo(CustomHabitDtoRequest habitDto, Habit habit) {