-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
839 implement the who we are page #891
Conversation
parsival2022
commented
Nov 13, 2024
•
edited
Loading
edited
…into 839-implement-the---who-we-are-page
…into 839-implement-the---who-we-are-page
} | ||
|
||
.about-us-section-content__header { | ||
margin-top: 80px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a redundant margin-top that doubles the 80px spacing. The parent class .about-us-section-main already has padding: 80px, which is enough.
} | ||
|
||
.about-us-section-content { | ||
padding: 40px 104px 48px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are redundant paddings. The parent class .about-us-section-main already provides the necessary spacing through its padding and gap properties.
.about-us-section-content__header { | ||
color: var(--about-us-header-color); | ||
margin-bottom: 24px; | ||
margin-top: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are redundant margins. The necessary spacing is provided through the padding and gap in .about-us-section-main class.
justify-content: center; | ||
align-items: center; | ||
overflow: hidden; | ||
padding-bottom: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is redundant padding-bottom. The necessary spacing is provided through the padding in .about-us-section-main class.
width: 375px; | ||
padding: 0 15px; | ||
display: flex; | ||
justify-content: space-between; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a redundant justify-content property. It has no effect on mobile and tablet screens. And it is only applied for screens > 1200px in media query.
min-width: 100vw; | ||
background: var(--about-us-background-color); | ||
justify-content: center; | ||
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are redundant justify-content and align-items properties that have no effect.