#300 load more information on profile page #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </span> | ||
| )} | ||
| </p>) : null | ||
| <> |
There was a problem hiding this comment.
No need to add a fragment if there is only one element
Comment on lines
29
to
33
| ? { | ||
| rows: 6, | ||
| expandable: true, | ||
| symbol: ellipsisSymbol, | ||
| } |
There was a problem hiding this comment.
Could we move it to constant with a meaningful name?
There was a problem hiding this comment.
Should we do it if it is Ant Design component and its structure?
| const { id } = useParams(); | ||
| const urlProfile = `${process.env.REACT_APP_BASE_API_URL}/api/profiles/${id}`; | ||
|
|
||
| async function fetcher(url) { | ||
| const headers = { | ||
| 'Content-Type': 'application/json', | ||
| }; | ||
| if (isAuthorized) { |
There was a problem hiding this comment.
Do we use isAuthorized in the component? If no could we remove it?
There was a problem hiding this comment.
It's passed to child components
popovycholeg
approved these changes
Nov 15, 2023
Shushunya
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read More component has been updated with Ant Design ellipsis according to design and clarified requirements.