#269 implement functionality of profile details #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popovycholeg
reviewed
Nov 8, 2023
| 'Соціальні мережі': [ | ||
| { | ||
| name: 'facebook', | ||
| url: '', | ||
| svgPath: <FacebookSvg />, | ||
| svgPath: <img src={`${process.env.PUBLIC_URL}/svg/facebook.svg`} />, |
There was a problem hiding this comment.
There are pros and cons for both options using SVG. Did you verify that we have PUBLIC_URL on devci? Does it work in CRA w/o REACT_APP prefix?
There was a problem hiding this comment.
Dev team still has no information about it. PUBLIC_URL is used not only in this component. We'll made changes if needed.
popovycholeg
reviewed
Nov 8, 2023
| return res.json(); | ||
| }) | ||
| .catch((error) => { | ||
| if (error.status === 401) { |
There was a problem hiding this comment.
Do we want to log error only if 401 occur?
There was a problem hiding this comment.
This component will be updated as soon as appropriate changes on back-end will be made. And I assume that this code will be removed.
popovycholeg
reviewed
Nov 8, 2023
FrontEnd/src/hooks/useUser.js
Outdated
| headers: { | ||
| 'Authorization': `Token ${authToken}`, | ||
| }, | ||
| }).then(res => res.json()), |
There was a problem hiding this comment.
Should we add error handling?
popovycholeg
approved these changes
Nov 8, 2023
…/github.com/ita-social-projects/Forum into #269-ImplementFunctionalityOfProfileDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile Detail page created and joined to API as it possible.
A lot of points are postponed because of absence related fields in db.