#260 add check password when delete profile #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shushunya
approved these changes
Oct 9, 2023
| @@ -174,6 +176,16 @@ def get_serializer_class(self): | |||
| else: | |||
| return ProfileOwnerDetailEditSerializer | |||
|
|
|||
| def destroy(self, request, *args, **kwargs): | |||
| instance = self.get_object() | |||
There was a problem hiding this comment.
Maybe it's better to use get_object_or_404 here?
There was a problem hiding this comment.
No. get_object_or_404() may be used in get_object() (if needed), but not here.
ProDG
reviewed
Oct 10, 2023
| user = self.request.user | ||
| password = self.request.data.get("password") | ||
| if not password or not check_password(password, user.password): | ||
| return Response(status=status.HTTP_400_BAD_REQUEST) |
There was a problem hiding this comment.
400 BAD REQUESTmust have a body, with explanation what exactly is wrong with the request. So, I guess this logic (together with password check) should be in serializer validator.- Don't, don't do
return Response().
There was a problem hiding this comment.
I wanted to do it in serializer, but there is no delete method in serializers, so I don't know how to implement it. I remember that it's not okay to return Response. But I just override original destroy method and it contains Response.
ProDG
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality of checking password when delete profile added (destroy method overridden). Tests (delete profile) updated due to changes.