Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#fix ghost test #253

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 26 additions & 23 deletions .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,26 @@
# too many errors in our frontend for usage this action, keep it for future...
#name: EsLint
#
#on: pull_request
#
#jobs:
# linting:
# name: Linting # job name (unique id)
# runs-on: ubuntu-latest # on which machine to run
# steps: # list of steps
# - name: Install NodeJS
# uses: actions/setup-node@v2
# with:
# node-version: '14'
#
# - name: Code Checkout
# uses: actions/checkout@v3
#
# - name: Install Dependencies
# run: npm ci
#
# - name: Code Linting
# run: npm run lint
name: EsLint

on: pull_request

jobs:
linting:
name: Linting # job name (unique id)
runs-on: ubuntu-latest # on which machine to run
steps: # list of steps
- name: Install NodeJS
uses: actions/setup-node@v2
with:
node-version: '14'

- name: Code Checkout
uses: actions/checkout@v3

- name: Install Dependencies
run: |
cd FrontEnd
npm install

- name: Code Linting
run: |
cd FrontEnd
npm run lint
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
# Label used to access the service container ?
postgres:
# Docker Hub image
image: postgres
image: postgres:14
# Provide the password for postgres
env:
POSTGRES_USER: postgres
Expand Down
29 changes: 10 additions & 19 deletions FrontEnd/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
"browser": true,
"es2021": true
},
"extends": ["eslint:recommended", "plugin:react/recommended", "plugin:react-hooks/recommended"],
"extends": [
"eslint:recommended",
"plugin:react/recommended",
"plugin:react-hooks/recommended"
],
"parserOptions": {
"ecmaVersion": 12,
"sourceType": "module",
Expand All @@ -24,29 +28,16 @@
"ignoreTemplateLiterals": true
}
],
"linebreak-style": [
"error",
"unix"
],
"quotes": [
"error",
"single"
],
"semi": [
"error",
"always"
],
"linebreak-style": ["error", "unix"],
"quotes": ["error", "single"],
"semi": ["error", "always"],
"no-console": [
"warn",
{
"allow": [
"warn",
"error",
"info"
]
"allow": ["warn", "error", "info"]
}
],
"no-trailing-spaces": 2,
"jsx-quotes": ["error", "prefer-double"]
}
}
}
Loading
Loading