Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#228 tests in actions #251

Merged
merged 4 commits into from
Oct 4, 2023
Merged

#228 tests in actions #251

merged 4 commits into from
Oct 4, 2023

Conversation

BelousSofiya
Copy link
Collaborator

@BelousSofiya BelousSofiya commented Oct 3, 2023

Add tests to git actions
For now these tests fail, because they were not changed after changing serializers in develop. You can see these tests in Testing BE / Testing (pull_request) in details

@BelousSofiya BelousSofiya changed the base branch from master to develop October 3, 2023 17:51
@BelousSofiya BelousSofiya requested review from ProDG and whooaami October 3, 2023 18:21
Comment on lines 4 to 17
env:
SECRET_KEY: django-insecure-8p_=_(i8$#=t_n26md(d7=gpc%5sss!4-1a0cp(lir3-0x^$8%
PG_DB: db
PG_USER: postgres
PG_PASSWORD: postgres
DB_HOST: 127.0.0.1
DB_PORT: 5432
EMAIL_BACKEND: django.core.mail.backends.smtp.EmailBackend
EMAIL_HOST: smtp.gmail.com
EMAIL_PORT: 587
EMAIL_USE_TLS: 1
EMAIL_HOST_USER: [email protected]
EMAIL_HOST_PASSWORD: evezhjqcfubkudrg
CORS_ORIGIN_WHITELIST: ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credentials should be hidden. Read about GitHub secrets.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for feedback. Done.

python manage.py makemigrations
python manage.py migrate
- name: running tests
run: python manage.py test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new empty line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried, but git deleted it again

@BelousSofiya BelousSofiya merged commit 324bf58 into develop Oct 4, 2023
1 of 2 checks passed
@BelousSofiya BelousSofiya deleted the #228TestsInActions branch October 4, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants