-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#228 tests in actions #251
Conversation
.github/workflows/tests.yml
Outdated
env: | ||
SECRET_KEY: django-insecure-8p_=_(i8$#=t_n26md(d7=gpc%5sss!4-1a0cp(lir3-0x^$8% | ||
PG_DB: db | ||
PG_USER: postgres | ||
PG_PASSWORD: postgres | ||
DB_HOST: 127.0.0.1 | ||
DB_PORT: 5432 | ||
EMAIL_BACKEND: django.core.mail.backends.smtp.EmailBackend | ||
EMAIL_HOST: smtp.gmail.com | ||
EMAIL_PORT: 587 | ||
EMAIL_USE_TLS: 1 | ||
EMAIL_HOST_USER: [email protected] | ||
EMAIL_HOST_PASSWORD: evezhjqcfubkudrg | ||
CORS_ORIGIN_WHITELIST: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Credentials should be hidden. Read about GitHub secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for feedback. Done.
.github/workflows/tests.yml
Outdated
python manage.py makemigrations | ||
python manage.py migrate | ||
- name: running tests | ||
run: python manage.py test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried, but git deleted it again
Add tests to git actions
For now these tests fail, because they were not changed after changing serializers in develop. You can see these tests in Testing BE / Testing (pull_request) in details