#136 about us navigation #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| id: "pnl3", | ||
| title: "Про нас", | ||
| link: "/#about-us", |
There was a problem hiding this comment.
no need to add / before anchor
There was a problem hiding this comment.
This is the anchor for the main page section and without slash it tries to find the anchor on the other page. So this slash is necessary since we need to have this functionality working from any place.
| </div> | ||
| <div className={css["navigation-content-section"]}> | ||
| {SERVICES_LINKS.map((element) => ( | ||
| <a |
There was a problem hiding this comment.
Since we use react router for the entire app, its better to use Link from the react-router to utilize full power of SPA
There was a problem hiding this comment.
As far as I know, Link doesn't support anchor links. That's why I decided to use HashLink.
| }, | ||
| { | ||
| id: "m3", | ||
| title: "Про нас", | ||
| link: "#" | ||
| link: "/#about-us" |
There was a problem hiding this comment.
same no need to put / with #hash-fragment
popovycholeg
approved these changes
Aug 31, 2023
RedSSD
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User story:
As a user,
I want to review the information about platform
So that I understand what this platform offers and if I am interested in it.
Given I am on the platform
When I click on 'Про нас' button
Then I am redirected to 'Про нас' section on the main page