Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 code conven pylint #12

Merged
merged 3 commits into from
Nov 19, 2023
Merged

#6 code conven pylint #12

merged 3 commits into from
Nov 19, 2023

Conversation

GodaimeSan22
Copy link
Collaborator

@GodaimeSan22 GodaimeSan22 commented Nov 17, 2023 •
edited
Loading

dev

JIRA

Code reviewers

Second Level Review

  • @VD-888

Summary of issue

Create code convention.md and pylint

Summary of change

Added pylint to workflow (branch develop) in the pylint.yml

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@GodaimeSan22 GodaimeSan22 changed the base branch from master to develop November 17, 2023 11:14
@GodaimeSan22 GodaimeSan22 linked an issue Nov 17, 2023 that may be closed by this pull request
Code Convention .md file and pylint #6
Open
@romanmyko romanmyko merged commit e881825 into develop Nov 19, 2023
@romanmyko romanmyko mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalyna mehalyna Awaiting requested review from mehalyna

@VovaD199 VovaD199 Awaiting requested review from VovaD199

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Convention .md file and pylint
2 participants
@GodaimeSan22 @romanmyko