Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI note and channel mix up #2

Open
cannc4 opened this issue Dec 26, 2021 · 1 comment
Open

MIDI note and channel mix up #2

cannc4 opened this issue Dec 26, 2021 · 1 comment
Assignees

Comments

@cannc4
Copy link

cannc4 commented Dec 26, 2021

Hey, I wanted to give it a run with my op-1 while traveling and noticed odd behavior when I try to send different notes within the same channel. I guess you've built the core of the cpp with bearing rytm in mind - perhaps more to add to this bit?

  if (track == 64) { // clock alias
        mm[0] = 0xF8;
        mb.push_back(mm);
      } else { // regular track

        // all ccs
        for (const auto &cc : ccs) {
          mm[0] = 0xb0 | track;
          mm[1] = cc.first;
          mm[2] = cc.second;
          mb.push_back(mm);
        }

        // note change (..?)
        mm[0] = 0xB0 | track;
        mm[1] = 0x03;
        mm[2] = 0x3C + note;
        mb.push_back(mm);

        // note on
        mm[0] = 0x90 | track;
        mm[1] = track;
        mm[2] = 0x7F;
        mb.push_back(mm);
      }
      ```
@isyuck isyuck self-assigned this Dec 27, 2021
@isyuck
Copy link
Owner

isyuck commented Dec 27, 2021

interesting, i was changing notes on the rytm by using a CC, rather than inside note on messages. try out this branch device-agnosticism, it should work better for your purposes. turns out i needed less code in that bit haha!

i'd recommend using midinote, as n and note are remapped for the rytm. probably best to modify BootTidal.hs and do something like note = midinote etc. there is also support for velocity in this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants