[FE]シュミレーターの椅子を切り替えれない代わりに、3つの椅子をページとして用意する #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imamiya-masaki
changed the title
imamiya-masaki
changed the title
narirou
reviewed
Dec 4, 2024
frontend/app/globals.d.ts
Outdated
| @@ -10,12 +10,12 @@ declare const __INITIAL_OWNER_DATA__: | |||
| name: string; | |||
| token: string; | |||
| }[]; | |||
| targetSimulatorChair: { | |||
| simulatorChairs: { | |||
There was a problem hiding this comment.
処理が少し散らばっているのが気になりました
when?: DomainName にしてマッチしたときに利用するという処理はどうでしょうか？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今の実装だと、椅子が一台しかないので、競技者3人がブラウザで操作することが不可能になる
これに関しては、例年の方針を採用することで解決できそう (クッキーはオリジン単位なので)
参考: https://gist.github.com/mackee/4320c18919c8f6f1867849378a17e651#%E5%8B%95%E4%BD%9C%E7%A2%BA%E8%AA%8D%E3%81%AE%E3%81%9F%E3%82%81%E3%81%AEhosts%E3%83%95%E3%82%A1%E3%82%A4%E3%83%AB%E8%A8%AD%E5%AE%9A
2024-12-04.10.48.06.mov