Merge pull request #714 from isucon/feature/retry_after_ms.node

feat(node): retry_after_msを返すように
isucon · Dec 7, 2024 · f471035 · f471035
2 parents f7a27b4 + 42aaf0e
commit f471035
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/webapp/nodejs/src/app_handlers.ts b/webapp/nodejs/src/app_handlers.ts
@@ -496,6 +496,7 @@ type AppGetNotificationResponseData = {
 
 type AppGetNotificationResponse = {
   data: AppGetNotificationResponseData;
+  retry_after_ms?: number;
 };
 
 export const appGetNotification = async (ctx: Context<Environment>) => {
@@ -508,7 +509,7 @@ export const appGetNotification = async (ctx: Context<Environment>) => {
       [user.id],
     );
     if (!ride) {
-      return ctx.json({}, 200);
+      return ctx.json({ retry_after_ms: 30 }, 200);
     }
     const [[yetSentRideStatus]] = await ctx.var.dbConn.query<
       Array<RideStatus & RowDataPacket>
@@ -546,6 +547,7 @@ export const appGetNotification = async (ctx: Context<Environment>) => {
         created_at: ride.created_at.getTime(),
         updated_at: ride.updated_at.getTime(),
       },
+      retry_after_ms: 30,
     };
     if (ride.chair_id !== null) {
       const [[chair]] = await ctx.var.dbConn.query<

diff --git a/webapp/nodejs/src/chair_handlers.ts b/webapp/nodejs/src/chair_handlers.ts
@@ -120,7 +120,7 @@ export const chairGetNotification = async (ctx: Context<Environment>) => {
       [chair.id],
     );
     if (!ride) {
-      return ctx.json({}, 200);
+      return ctx.json({ retry_after_ms: 30 }, 200);
     }
 
     const [[yetSentRideStatus]] = await ctx.var.dbConn.query<
@@ -164,6 +164,7 @@ export const chairGetNotification = async (ctx: Context<Environment>) => {
           },
           status,
         },
+        retry_after_ms: 30,
       },
       200,
     );