Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend #41

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Frontend #41

merged 10 commits into from
Dec 6, 2024

Conversation

mishadr
Copy link
Collaborator

@mishadr mishadr commented Dec 5, 2024

Переработаны статистики по датасету. Создан класс DatasetStats, куда перенесены расчеты. Поправлено на фронте, что падало на направленных графах (кроме Attributes assortativity).

Copy link
Collaborator

@LukyanovKirillML LukyanovKirillML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько мест выделил, но если функция ничего не возвращает, то стоит указывать это через "-> None". Исключения это magic методы типо init. Я не все места выделил где был этот момент, поставь, пожалуйста, в остальных тоже.

active_sessions = {} # {session Id -> sid, process, conn}


def worker_process(process_id, conn, sid):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style

def remove(
self,
stat: str
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> None


def clear_all_stats(
self
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> None


def list_to_hist(
a_list: list
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> dict

@LukyanovKirillML LukyanovKirillML merged commit 33a185a into develop Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants