CI: Add workflow for v1.13 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
force-pushed
the
pr/tp/v1.13-ci-conformance
branch
from
d35c563
to
4b15fab
Compare
v1.14 had some breaking changes to configuration, namely simplification of the kpr configuration and changes for compatibility for l7 and encryption. To make things easier, this introduces v1.13 as a seperate workflow to avoid having special case logic between v1.13 and more recent versions. Upon releasing v1.16 we can remove this workflow and just use conformance.yaml. Signed-off-by: Tom Hadlaw <[email protected]>
Also, adds missing flag to enable sysdumps upon failure. Signed-off-by: Tom Hadlaw <[email protected]>
tommyp1ckles
force-pushed
the
pr/tp/v1.13-ci-conformance
branch
from
4b15fab
to
96cdfef
Compare
PhilipSchmid
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
LGTM. Thanks!
Just one question: Do you think we should build a retry around the cilium-cli install command? -> https://github.com/isovalent/terraform-aws-talos/actions/runs/8237765455/job/22543525926?pr=38#step:7:30
|
@PhilipSchmid yeah good idea, there's some issues with the CI right now due to cleanups failing so ill address and such issues in a seperate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.