Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added edit_text function #7

Merged
merged 1 commit into from
Nov 4, 2019
Merged

added edit_text function #7

merged 1 commit into from
Nov 4, 2019

Conversation

Pkpratik
Copy link
Contributor

@Pkpratik Pkpratik commented Nov 4, 2019

first call the edit_text function then the generate_pdf function.
example:
edit_text("red",22,"Helvetica")
generate_pdf("hello world")

@Pkpratik
added edit_text function
c2f584a 
first call the edit_text function then the generate_pdf function.
example:
edit_text("red",22,"Helvetica")
generate_pdf("hello world")
shashank-sharma
shashank-sharma approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@shashank-sharma shashank-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes required, but we can iterate over it in our next call, till then I guess approach is correct

@shashank-sharma shashank-sharma merged commit 12b0ceb into isohack:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashank-sharma shashank-sharma shashank-sharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pkpratik @shashank-sharma