Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package created #13

Merged
merged 1 commit into from
Dec 21, 2019
Merged

package created #13

merged 1 commit into from
Dec 21, 2019

Conversation

Rodio346
Copy link
Contributor

Sir please have a look at the commit

Copy link
Member

@shashank-sharma shashank-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Specify virtualenv usage in readme.md
  2. no .pyc should be committed
  3. A bit of improvement in module

So I'll merge this and make changes, this review is to let you know what you could have done extra

@shashank-sharma shashank-sharma merged commit 9bcb48e into isohack:master Dec 21, 2019
@shashank-sharma
Copy link
Member

Never mind, it's way too messed up right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants