Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NL.9 ALL_CAPS does not apply to non-macro symbolic constants #2130

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix NL.9 ALL_CAPS does not apply to non-macro symbolic constants #2130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bea791
fix NL.9 ALL_CAPS does not apply to non-macro symbolic constants
kimim Sep 2, 2023
175a720
Update CppCoreGuidelines.md
kimim Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CppCoreGuidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21643,7 +21643,7 @@ To avoid confusing macros with names that obey scope and type rules.

##### Note

This rule applies to non-macro symbolic constants:
In particular, this avoids confusing macros with non-macro symbolic constants (see also [Enum.5: Don't use `ALL_CAPS` for enumerators](#Renum-caps))

enum bad { BAD, WORSE, HORRIBLE }; // BAD

Expand Down