Skip to content

Commit

Permalink
Use attach()/detach() functions instead of touching .references
Browse files Browse the repository at this point in the history
In rbtdb.c, there were two places where the code touched .references
directly instead of using the helper functions.  Use the helper
functions instead.
  • Loading branch information
oerdnj committed Nov 27, 2024
1 parent 60be885 commit a4e3d25
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions lib/dns/rbtdb.c
Original file line number Diff line number Diff line change
Expand Up @@ -2483,10 +2483,7 @@ cleanup_dead_nodes_callback(isc_task_t *task, isc_event_t *event) {
isc_task_send(task, &event);
} else {
isc_event_free(&event);
if (isc_refcount_decrement(&rbtdb->references) == 1) {
(void)isc_refcount_current(&rbtdb->references);
maybe_free_rbtdb(rbtdb);
}
detach((dns_db_t **)&rbtdb);
}
}

Expand Down Expand Up @@ -2749,7 +2746,7 @@ closeversion(dns_db_t *db, dns_dbversion_t **versionp, bool commit) {
sizeof(*changed));
}
if (event != NULL) {
isc_refcount_increment(&rbtdb->references);
attach((dns_db_t *)rbtdb, &(dns_db_t *){ NULL });
isc_task_send(rbtdb->task, &event);
} else {
RWUNLOCK(&rbtdb->tree_lock, isc_rwlocktype_write);
Expand Down

0 comments on commit a4e3d25

Please sign in to comment.