Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @recast-navigation/playcanvas package #438

Merged
merged 34 commits into from
Oct 15, 2024
Merged

Add @recast-navigation/playcanvas package #438

merged 34 commits into from
Oct 15, 2024

Conversation

isaac-mason
Copy link
Owner

No description provided.

@marklundin
Copy link
Contributor

Hey @isaac-mason just checking if you need anything more from me on this. Happy to jump in to help move things forward :D

@isaac-mason
Copy link
Owner Author

isaac-mason commented Oct 9, 2024

Hey @marklundin, I think this branch is just about ready to merge and get out there!

It would be great if you could take a look at the standalone playcanvas example I added, as well as take a look at changes I made to @recast-navigation/playcanvas. I'm not deeply familiar with playcanvas so let me know if I should revert/amend any of the changes I made.

You can see the standalone playcanvas example I added here: https://github.com/isaac-mason/recast-navigation-js/pull/438/files#diff-6eb676771678639035973890d1cfb6f747c48365ce2f343f6500725f77be662a
It would be good to extend it to use more/all of the helpers in @recast-navigation/playcanvas too, so we can easily test for regressions in this repo.

The main changes I made to @recast-navigation/playcanvas are:

  • removing the need to pass a graphics device to the generator helpers eg pcToSoloNavMesh
  • moving common debug draw utils into the core library
  • prettier blast and small refactors

@isaac-mason isaac-mason marked this pull request as ready for review October 15, 2024 04:04
@isaac-mason isaac-mason merged commit 98b833b into main Oct 15, 2024
1 check passed
@isaac-mason isaac-mason deleted the playcanvas branch October 15, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants