Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for GNOME v3.12 Compatibility #107

Closed
wants to merge 2 commits into from

Conversation

jheretic
Copy link

@jheretic jheretic commented May 1, 2014

I'm afraid I'm not terribly familiar with the structuring of GNOME extensions. However, I integrated the fixes suggested by @svu in #104 and it seems to work for me. I was not able to test on previous GNOME versions.

@ouchadam
Copy link

👍 I would also love to see this merged

@yanickrochon
Copy link

Just installed this and am running gnome shell 3.12 and the extension is not compatible at the moment. Perhaps do a branch....

@warmsun0220
Copy link
Contributor

i have test it and it works very well, hope merge it soon!

@wbober
Copy link

wbober commented May 30, 2014

I've tested it too. Works fine.

adrianbroher added a commit that referenced this pull request Jun 3, 2014
@adrianbroher
Copy link
Collaborator

Please try out if the changes I pushed recently work out for you.

@UshakovVasilii
Copy link

Don't work without ' and \

@mijoharas
Copy link

I am currently unable to install from the gnome extensions site should it be working or should I look into it?

@adrianbroher
Copy link
Collaborator

Both issues should be addressed now.

The invalid dbus interface should be fixed with the commits e6d4db and e0a6c5.

The support for Gnome Shell 3.12 was added with commit b17877.

I assume this issue can be closed now. If the problems still persist please open a new issue.

@mijoharas
You can follow #102 if you want to.

@mijoharas
Copy link

Looks like you're supporting 3.16 as well. Thanks @adrianbroher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants