Feature/new metrics #25
Conversation
| @@ -0,0 +1,78 @@ | |||
| package metrics | |||
There was a problem hiding this comment.
Could you please add the license text also here like in main.go ?
| @@ -0,0 +1,53 @@ | |||
| package metrics | |||
There was a problem hiding this comment.
Could you please add the license text also here like in main.go ?
main.go
Outdated
| break | ||
| go func() { | ||
| for { | ||
| if !testDpdkConnection() { |
There was a problem hiding this comment.
I was testing the new functionality of the "reconnect" in case dpservice gets restarted.
It works as expected, if the dpservice is down and gets restarted in a time period which is longer than time.Duration(pollIntervalFlag) * time.Second. If it is shorter than that (dpservice gets stopped/started quickcly)
I get such an output. Can you also detect this error and try to reconnect to dpservice ?
sudo ./bin/prometheus-dpdk-exporter
{"level":"info","msg":"Hostname: guvenc-vm","time":"2024-04-11T19:15:44+02:00"}
{"level":"info","msg":"Server starting on :8080...","time":"2024-04-11T19:15:44+02:00"}
{"level":"error","msg":"Failed to send command to /var/run/dpdk/rte/dpdk_telemetry.v2: write unixpacket @-\u003e/var/run/dpdk/rte/dpdk_telemetry.v2: write: broken pipe","time":"2024-04-11T19:16:04+02:00"}
{"level":"error","msg":"Failed to send command to /var/run/dpdk/rte/dpdk_telemetry.v2: write unixpacket @-\u003e/var/run/dpdk/rte/dpdk_telemetry.v2: write: broken pipe","time":"2024-04-11T19:16:04+02:00"}
{"level":"error","msg":"Failed to send command to /var/run/dpdk/rte/dpdk_telemetry.v2: write unixpacket @-\u003e/var/run/dpdk/rte/dpdk_telemetry.v2: write: broken pipe","time":"2024-04-11T19:16:04+02:00"}
{"level":"error","msg":"Failed to send command to /var/run/dpdk/rte/dpdk_telemetry.v2: write unixpacket @-\u003e/var/run/dpdk/rte/dpdk_telemetry.v2: write: broken pipe","time":"2024-04-11T19:16:04+02:00"}
There was a problem hiding this comment.
I reworked the testing function and now it should handle also this short interruption without error.
github-actions
bot
added
the
documentation
Refactored code: split the code into packages and functions.
Change of log format to comply with requirements.
Added Dockerfile and build, run, ... steps in Makefile.
Port on which exporter is running can be now set via flag.
Added reconnect attempt after dpservice went down and up again.
Added new Dpservice metric: virtsvc_used_port_count