Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CreateOrPatch for dependent resources like BMC, Server,ServerBootConfiguration #71

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Use CreateOrPatch for dependent resources like BMC, Server,ServerBootConfiguration #71

merged 1 commit into from
Jul 4, 2024

Conversation

afritzler
Copy link
Member

@afritzler afritzler commented Jul 4, 2024 •
edited
Loading

Proposed Changes

Use CreateOrPatch for dependent resources like BMC, Server,ServerBootConfiguration

@github-actions github-actions bot added size/S bug Something isn't working labels Jul 4, 2024
@afritzler afritzler force-pushed the fix/bmc-reconciler branch from 53a4d84 to 5bb23c6 Compare July 4, 2024 11:31
@afritzler afritzler changed the title Use CreateOrUpdate in Server creation Use CreateOrPatch in Server detection in the BMCReconciler Jul 4, 2024
@afritzler afritzler requested a review from hardikdr July 4, 2024 11:33
@afritzler afritzler force-pushed the fix/bmc-reconciler branch from 5bb23c6 to 5494061 Compare July 4, 2024 11:53
@github-actions github-actions bot added size/M and removed size/S labels Jul 4, 2024
@afritzler afritzler changed the title Use CreateOrPatch in Server detection in the BMCReconciler Use CreateOrPatch for dependent resources like BMC, Server,ServerBootConfiguration Jul 4, 2024
@afritzler afritzler force-pushed the fix/bmc-reconciler branch from 5494061 to 686ecf4 Compare July 4, 2024 11:56
hardikdr
hardikdr approved these changes Jul 4, 2024
View reviewed changes
internal/controller/bmc_controller.go Outdated Show resolved Hide resolved
@afritzler afritzler force-pushed the fix/bmc-reconciler branch from 686ecf4 to 4ebafc0 Compare July 4, 2024 11:59
@afritzler afritzler merged commit 37d9006 into main Jul 4, 2024
8 checks passed
@afritzler afritzler deleted the fix/bmc-reconciler branch July 4, 2024 12:01
@afritzler afritzler mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afritzler @hardikdr