Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker Build #6

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix Docker Build #6

merged 1 commit into from
Jul 25, 2024

Conversation

hardikdr
Copy link
Member

Proposed Changes

Fixes #

@github-actions github-actions bot added bug Something isn't working size/XS labels Jul 25, 2024
@hardikdr hardikdr added the ok-to-image Allow building the docker image for the PR label Jul 25, 2024
@github-actions github-actions bot added size/S and removed size/XS labels Jul 25, 2024
@hardikdr hardikdr added ok-to-image Allow building the docker image for the PR and removed ok-to-image Allow building the docker image for the PR labels Jul 25, 2024
@hardikdr hardikdr requested a review from defo89 July 25, 2024 13:39
@hardikdr hardikdr added the do-not-merge Do not merge label Jul 25, 2024
defo89
defo89 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@defo89 defo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hardikdr hardikdr added ok-to-image Allow building the docker image for the PR and removed ok-to-image Allow building the docker image for the PR do-not-merge Do not merge labels Jul 25, 2024
@hardikdr hardikdr merged commit e3c9589 into main Jul 25, 2024
9 checks passed
@hardikdr hardikdr deleted the fix/dockerfile branch July 25, 2024 14:24
@hardikdr hardikdr added bug Something isn't working and removed bug Something isn't working labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defo89 defo89 defo89 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ok-to-image Allow building the docker image for the PR size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardikdr @defo89