Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile create pin #94

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Mobile create pin #94

wants to merge 18 commits into from

Conversation

cgjohn
Copy link
Contributor

@cgjohn cgjohn commented Dec 13, 2024

pin-flow.mp4

implements this flow from figma

Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it's functional! Might want to grab a review from Dan as well though since he's probably more informed on the frontend 😄


const handleKeyDown = (index: number, e: KeyboardEvent) => {
if (e.key === "Backspace" && index > 0) {
console.log("running handleKeyDown and isBackspace", index);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@dgca dgca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably wanna remove that console.log, but lgtm otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants