Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold top portion of balances page #72

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

dgca
Copy link
Contributor

@dgca dgca commented Dec 2, 2024

@@ -4,5 +4,6 @@ module.exports = {
plugins: ["prettier"],
rules: {
"prettier/prettier": "error",
"import/no-unresolved": "off",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out how to set up path aliases while also making ESLint happy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only suggestion would be to add a comment for why we have it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed it hah

@@ -6,40 +6,33 @@ type Sizes = "4xl" | "3xl" | "2xl" | "xl" | "lg" | "md" | "sm" | "xs";
const styles = css.create({
base: {
fontFamily: "Favorit",
textAlign: "center",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not get overwritten by the textAlign prop that we default to left?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@@ -0,0 +1 @@
/// <reference types="vite-plugin-svgr/client" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what fixed the import error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, this was to get SVGs working. The thing that fixed the import error message is here: https://github.com/iron-fish/mobile-wallet/pull/72/files#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357R7

Copy link
Contributor

@cgjohn cgjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two tiny thoughts but lgtm!

@dgca dgca merged commit 58b4dc5 into main Dec 3, 2024
2 checks passed
@dgca dgca deleted the icon-button-for-real-this-time branch December 3, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants