-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold top portion of balances page #72
Conversation
dgca
commented
Dec 2, 2024
•
edited
Loading
edited
packages/mobile-app/.eslintrc.js
Outdated
@@ -4,5 +4,6 @@ module.exports = { | |||
plugins: ["prettier"], | |||
rules: { | |||
"prettier/prettier": "error", | |||
"import/no-unresolved": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't figure out how to set up path aliases while also making ESLint happy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only suggestion would be to add a comment for why we have it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed it hah
@@ -6,40 +6,33 @@ type Sizes = "4xl" | "3xl" | "2xl" | "xl" | "lg" | "md" | "sm" | "xs"; | |||
const styles = css.create({ | |||
base: { | |||
fontFamily: "Favorit", | |||
textAlign: "center", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not get overwritten by the textAlign
prop that we default to left
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
@@ -0,0 +1 @@ | |||
/// <reference types="vite-plugin-svgr/client" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what fixed the import error message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, this was to get SVGs working. The thing that fixed the import error message is here: https://github.com/iron-fish/mobile-wallet/pull/72/files#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357R7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two tiny thoughts but lgtm!