Add Oreowallet server API #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgca
reviewed
Nov 27, 2024
dgca
reviewed
Nov 27, 2024
| let lastTime = performance.now(); | ||
| // Make sure the account exists | ||
| const account = await this.state.db.getAccount(accountName); | ||
| if (account == null) { |
There was a problem hiding this comment.
nit (non-blocking): I assume you want ===, but no biggie. Could add a lint rule for that later.
There was a problem hiding this comment.
Actually this is intentional, I just habitually use this to as shorthand for account === null || account === undefined. But no strong preference here if we want to throw in a lint rule for it
dgca
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a debug page as well as an implementation of the oreowallet API. Tested importing an account, fetching balances/transactions, and creating an account with locally-generated proofs.
For now we'll generate proofs on-device since that's already built. To use the proving server, we'd need to update the Iron Fish rust crate to support adding proofs to an existing transaction.